[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 14/22] block: Set default request_alignment durin
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v3 14/22] block: Set default request_alignment during bdrv_refresh_limits() |
Date: |
Thu, 23 Jun 2016 16:37:18 -0600 |
We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.
Now that all drivers have been updated to supply an override
of request_alignment during their .bdrv_refresh_limits(), as
needed, the block layer itself can defer setting the default
alignment until part of the overall bdrv_refresh_limits().
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
v3: no change
v2: new patch
---
block.c | 1 -
block/io.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index f4648e9..c2fbf06 100644
--- a/block.c
+++ b/block.c
@@ -937,7 +937,6 @@ static int bdrv_open_common(BlockDriverState *bs, BdrvChild
*file,
goto fail_opts;
}
- bs->request_alignment = drv->bdrv_co_preadv ? 1 : 512;
bs->read_only = !(bs->open_flags & BDRV_O_RDWR);
if (use_bdrv_whitelist && !bdrv_is_whitelisted(drv, bs->read_only)) {
diff --git a/block/io.c b/block/io.c
index 82c9ff0..323e822 100644
--- a/block/io.c
+++ b/block/io.c
@@ -78,6 +78,9 @@ void bdrv_refresh_limits(BlockDriverState *bs, Error **errp)
return;
}
+ /* Default alignment based on whether driver has byte interface */
+ bs->request_alignment = drv->bdrv_co_preadv ? 1 : 512;
+
/* Take some limits from the children as a default */
if (bs->file) {
bdrv_refresh_limits(bs->file->bs, &local_err);
--
2.5.5
- Re: [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512, (continued)
- [Qemu-devel] [PATCH v3 01/22] block: Tighter assertions on bdrv_aligned_pwritev(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 13/22] block: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 10/22] iscsi: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 17/22] block: Switch discard length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 14/22] block: Set default request_alignment during bdrv_refresh_limits(),
Eric Blake <=
- [Qemu-devel] [PATCH v3 21/22] block: Fix error message style, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 03/22] block: Fix harmless off-by-one in bdrv_aligned_preadv(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 12/22] raw-win32: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 11/22] qcow2: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 22/22] block: Use bool as appropriate for BDS members, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 19/22] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 20/22] block: Move request_alignment into BlockLimit, Eric Blake, 2016/06/23