[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 18/22] block: Drop raw_refresh_limits()
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 18/22] block: Drop raw_refresh_limits() |
Date: |
Fri, 24 Jun 2016 14:44:14 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, 06/23 16:37, Eric Blake wrote:
> The raw block driver was blindly copying all limits from bs->file,
> even though: 1. the main bdrv_refresh_limits() already does this
> for many of the limits, and 2. blindly copying from the children
> can weaken any stricter limits that were already inherited from
> the backing chain during the main bdrv_refresh_limits(). Also,
> a future patch is about to move .request_alignment into
> BlockLimits, and that is a limit that should NOT be copied from
> other layers in the BDS chain.
>
> Thus, we can completely drop raw_refresh_limits(), and rely on
> the block layer setting up the proper limits.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v3: new patch, split out from 'block: Split bdrv_merge_limits()...'
> ---
> block/raw_bsd.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> index 7f63791..5855e84 100644
> --- a/block/raw_bsd.c
> +++ b/block/raw_bsd.c
> @@ -1,6 +1,6 @@
> /* BlockDriver implementation for "raw"
> *
> - * Copyright (C) 2010, 2013, Red Hat, Inc.
> + * Copyright (C) 2010-2016 Red Hat, Inc.
> * Copyright (C) 2010, Blue Swirl <address@hidden>
> * Copyright (C) 2009, Anthony Liguori <address@hidden>
> *
> @@ -150,11 +150,6 @@ static int raw_get_info(BlockDriverState *bs,
> BlockDriverInfo *bdi)
> return bdrv_get_info(bs->file->bs, bdi);
> }
>
> -static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
> -{
> - bs->bl = bs->file->bs->bl;
> -}
> -
> static int raw_truncate(BlockDriverState *bs, int64_t offset)
> {
> return bdrv_truncate(bs->file->bs, offset);
> @@ -252,7 +247,6 @@ BlockDriver bdrv_raw = {
> .bdrv_getlength = &raw_getlength,
> .has_variable_length = true,
> .bdrv_get_info = &raw_get_info,
> - .bdrv_refresh_limits = &raw_refresh_limits,
> .bdrv_probe_blocksizes = &raw_probe_blocksizes,
> .bdrv_probe_geometry = &raw_probe_geometry,
> .bdrv_media_changed = &raw_media_changed,
> --
> 2.5.5
>
Reviewed-by: Fam Zheng <address@hidden>
- [Qemu-devel] [PATCH v3 19/22] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), (continued)
- [Qemu-devel] [PATCH v3 19/22] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 20/22] block: Move request_alignment into BlockLimit, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 16/22] block: Wording tweaks to write zeroes limits, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 18/22] block: Drop raw_refresh_limits(), Eric Blake, 2016/06/23
- Re: [Qemu-devel] [PATCH v3 18/22] block: Drop raw_refresh_limits(),
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v3 00/22] Byte-based block limits, Kevin Wolf, 2016/06/24