[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Change of max-ram-below-4g initial value breaks Xen
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] Change of max-ram-below-4g initial value breaks Xen |
Date: |
Fri, 24 Jun 2016 12:19:04 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, Jun 24, 2016 at 07:46:23AM +0200, Gerd Hoffmann wrote:
> On Do, 2016-06-23 at 17:18 +0100, Anthony PERARD wrote:
> > On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > How could xen_ram_init() find out if the value of max-ram-below-4g is
> > > > the default or if a user have set it? Is there another way we could fix
> > > > this?
> > >
> > > Attached patch should fix it. Patch survived a quick smoke test on kvm
> > > so far, need to do some more testing tomorrow. Can you give it a spin
> > > on xen?
> >
> > Thanks. Unfortunately, it does not work :(.
> >
> > In this patch, max_ram_below_4g is set before the call to xen_ram_init()
> > and xen_ram_init read it back (via object_property_get_int()). So, in
> > xen_ram_init, user_lowmem is not 0.
>
> Ah, I see. We do the split calculation twice on xen. That is pretty
> pointless. New patch attached.
I've tested on Xen, it works fine. Thanks. Also, the patch look good.
Cheers,
--
Anthony PERARD