[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove |
Date: |
Fri, 24 Jun 2016 13:13:28 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-André Lureau wrote:
> On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin <address@hidden> wrote:
> >> > Maybe what you want is a need_unlink feature.
> >> > Set it for unix sockets only, that would make some sense.
> >>
> >> Oh perhaps what you mean is that if the fd was passed, we should cleanup
> >> the unix socket? Yes, I think we should do that then. I'll update the
> >> series.
>
> Actually it's not possible to pass a listening fd to a socket chardev
> today (the path argument doesn't understand /dev/fdset), so only path
> created by qemu will be cleaned up.
>
> >
> > I'd like it better contained - that's all. So let's set a flag that says
> > "must unlink" as opposed to "it's listening".
>
> You suggest to rename QIO_CHANNEL_FEATURE_LISTEN to
> QIO_CHANNEL_FEATURE_LISTEN_MUST_UNLINK ? Or to add another feature
> flag? I don't think that brings anything useful here.
IMHO the existing QIO_CHANNEL_FEATURE_LISTEN makes more sense than
a QIO_CHANNEL_FEATURE_MUST_UNLINK, so I'd like to see your current
patches go in as is.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when leaving, (continued)
- [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when leaving, marcandre . lureau, 2016/06/16
- [Qemu-devel] [PATCH v2 2/3] socket: add listen feature, marcandre . lureau, 2016/06/16
- [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, marcandre . lureau, 2016/06/16
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Marc-André Lureau, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Marc-André Lureau, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove,
Daniel P. Berrange <=
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Daniel P. Berrange, 2016/06/27
Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Daniel P. Berrange, 2016/06/23
Re: [Qemu-devel] [PATCH v2 0/3] chardev cleanups, Paolo Bonzini, 2016/06/17