[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 09/23] vhost: fix calling vhost_dev_cleanup() aft
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PATCH v2 09/23] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init() |
Date: |
Fri, 24 Jun 2016 15:50:56 +0200 |
From: Marc-André Lureau <address@hidden>
vhost_net_init() calls vhost_dev_init() and in case of failure, calls
vhost_dev_cleanup() directly. However, the structure is already
partially cleaned on error. Calling vhost_dev_cleanup() again will call
vhost_virtqueue_cleanup() on already clean queues, and causing potential
double-close. Instead, adjust dev->nvqs and simplify vhost_dev_init()
code to call vhost_virtqueue_cleanup().
Signed-off-by: Marc-André Lureau <address@hidden>
---
hw/virtio/vhost.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 1fdf109..314e0e7 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -1025,7 +1025,8 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
for (i = 0; i < hdev->nvqs; ++i) {
r = vhost_virtqueue_init(hdev, hdev->vqs + i, hdev->vq_index + i);
if (r < 0) {
- goto fail_vq;
+ hdev->nvqs = i;
+ goto fail;
}
}
hdev->features = features;
@@ -1071,14 +1072,9 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
memory_listener_register(&hdev->memory_listener, &address_space_memory);
QLIST_INSERT_HEAD(&vhost_devices, hdev, entry);
return 0;
-fail_vq:
- while (--i >= 0) {
- vhost_virtqueue_cleanup(hdev->vqs + i);
- }
+
fail:
- r = -errno;
- hdev->vhost_ops->vhost_backend_cleanup(hdev);
- QLIST_REMOVE(hdev, entry);
+ vhost_dev_cleanup(hdev);
return r;
}
--
2.9.0
- [Qemu-devel] [PATCH v2 02/23] vhost-user: minor simplification, (continued)
- [Qemu-devel] [PATCH v2 02/23] vhost-user: minor simplification, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 01/23] misc: indentation, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 03/23] vhost: don't assume opaque is a fd, use backend cleanup, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 08/23] vhost-net: always call vhost_dev_cleanup() on failure, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 04/23] vhost: make vhost_log_put() idempotent, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 05/23] vhost: call vhost_log_put() on cleanup, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 06/23] vhost: add vhost device only after all success, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 07/23] vhost: make vhost_dev_cleanup() idempotent, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 15/23] vhost-user: keep vhost_net after a disconnection, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 09/23] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init(),
marcandre . lureau <=
- [Qemu-devel] [PATCH v2 10/23] vhost: change some assert() for error_report() or silent fail, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 11/23] vhost: use error_report() instead of fprintf(stderr, ...), marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 12/23] vhost-user: check qemu_chr_fe_set_msgfds() return value, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 16/23] Revert "vhost-net: do not crash if backend is not present", marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 14/23] qemu-char: check socket is actually connected, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 18/23] vhost-net: success if backend has no ops->vhost_migration_done, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 17/23] get_vhost_net() should be != null after vhost_user_init, marcandre . lureau, 2016/06/24
- [Qemu-devel] [PATCH v2 22/23] vhost-user: wait until backend init is completed, marcandre . lureau, 2016/06/24