qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony targ


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony target
Date: Fri, 24 Jun 2016 09:17:30 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 06/24/2016 08:19 AM, Markus Armbruster wrote:
> Forgotten in commit b8c6f29.

Umm, really?  That commit starts with:

tests/Makefile
-.PHONY: check
+
+.PHONY: check check-block

Rather, I think it was b93b63f5 that accidentally lost it during an
overhaul.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 7b0446b..233cb9c 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c
>  
>  # Consolidated targets
>  
> -.PHONY: check-qapi-schema check-qtest check-unit check check-source 
> check-clean
> +.PHONY: check-qapi-schema check-qtest check-unit check check-block 
> check-source check-clean

Long line; worth splitting?

With commit message improved,
Reviewed-by: Eric Blake <address@hidden>



-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]