qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions have to


From: Sergey Fedorov
Subject: Re: [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions have to be called with tb_lock held
Date: Fri, 24 Jun 2016 18:38:35 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

On 03/06/16 23:40, Alex Bennée wrote:
> diff --git a/translate-all.c b/translate-all.c
> index e3f44d9..8b162ff 100644
> --- a/translate-all.c
> +++ b/translate-all.c
(snip)
> @@ -347,8 +349,10 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
>          cpu_restore_state_from_tb(cpu, tb, retaddr);
>          if (tb->cflags & CF_NOCACHE) {
>              /* one-shot translation, invalidate it immediately */
> +            tb_lock();
>              tb_phys_invalidate(tb, -1);
>              tb_free(tb);
> +            tb_unlock();

Looks like this belongs to another patch ;-)

>          }
>          return true;
>      }
>

Kind regards,
Sergey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]