Re: [Qemu-devel] [PULL 00/24] linux-user changes

[Riku Voipio]

On 24 June 2016 at 16:36, Peter Maydell <address@hidden> wrote:
> On 24 June 2016 at 10:52,  <address@hidden> wrote:
>> From: Riku Voipio <address@hidden>
>>
>> The following changes since commit c7288767523f6510cf557707d3eb5e78e519b90d:
>>
>>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160623' 
>> into staging (2016-06-23 11:53:14 +0100)
>>
>> are available in the git repository at:
>>
>>   git://git.linaro.org/people/riku.voipio/qemu.git 
>> tags/pull-linux-user-20160624
>>
>> for you to fetch changes up to 895b3c88e8ed1017bbcf0aa9aaf3d90754494ab5:
>>
>>   linux-user: Provide safe_syscall for ppc64 (2016-06-24 11:57:35 +0300)
>>
>> ----------------------------------------------------------------
>> Drop building linux-user targets on HPPA or m68k host systems
>> and add safe_syscall support for i386, aarch64, arm, ppc64 and
>> s390x.
>>
>> ----------------------------------------------------------------
>
> Unfortunately this doesn't build with clang:
>
> /home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:5665:24:
> error: unused function 'copy_from_user_eabi_flock64'
> [-Werror,-Wunused-function]
> static inline abi_long copy_from_user_eabi_flock64(struct flock64 *fl,
>                        ^
> /home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:5685:24:
> error: unused function 'copy_to_user_eabi_flock64'
> [-Werror,-Wunused-function]
> static inline abi_long copy_to_user_eabi_flock64(abi_ulong target_flock_addr,
>                        ^
> 2 errors generated.

interestingly I didn't see this error with my (clang-3.5) compile..

> These functions need to be guarded by
> #if defined(TARGET_ARM) && TARGET_ABI_BITS == 32
> not just #ifdef TARGET_ARM.

I've changed the patch in linux-user-for-upstream branch, retest and submit
tomorrow..

Riku