Re: [Qemu-devel] [PATCH] block/qcow2: Don't use cpu_to_*w()

[Peter Maydell]

On 20 June 2016 at 16:10, Max Reitz <address@hidden> wrote:
> On 16.06.2016 18:06, Peter Maydell wrote:
>> Don't use the cpu_to_*w() functions, which we are trying to deprecate.
>> Instead either just use cpu_to_*() to do the byteswap, or use
>> st*_be_p() if we need to do the store somewhere other than to a
>> variable that's already the correct type.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>>  block/qcow2-cluster.c  |  2 +-
>>  block/qcow2-refcount.c | 11 +++++------
>>  block/qcow2.c          |  6 +++---
>>  3 files changed, 9 insertions(+), 10 deletions(-)
>>
>
> [...]
>
>> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
>> index 66f187a..088c00f 100644
>> --- a/block/qcow2-refcount.c
>> +++ b/block/qcow2-refcount.c
>> @@ -565,8 +565,8 @@ static int alloc_refcount_block(BlockDriverState *bs,
>>          uint64_t d64;
>>          uint32_t d32;
>>      } data;
>
> This declaration is in the middle of the block, so it might have made
> sense to fix that along the way. Since this is pre-existing, however:
>
> Thanks, applied to my block tree:
>
> https://github.com/XanClic/qemu/commits/block

Ping? I don't think this has made it into a pullreq yet, and it's
freeze day today...

thanks
-- PMM