[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 5/7] util: add QAuthZ object as an authorizat
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v6 5/7] util: add QAuthZ object as an authorization base class |
Date: |
Wed, 29 Jun 2016 12:37:49 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jun 28, 2016 at 06:22:10PM +0200, Marc-André Lureau wrote:
> > +
> > +static const TypeInfo authz_info = {
> > + .parent = TYPE_OBJECT,
> > + .name = TYPE_QAUTHZ,
> > + .instance_size = sizeof(QAuthZ),
> > + .class_size = sizeof(QAuthZClass),
>
> .abstract = true? (perhaps it's not necessary, but that would be more clear)
Yes, makes sense to add that since you can't instantiate this class
and do anything useful with it.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v6 1/7] qdict: implement a qdict_crumple method for un-flattening a dict, (continued)
- [Qemu-devel] [PATCH v6 1/7] qdict: implement a qdict_crumple method for un-flattening a dict, Daniel P. Berrange, 2016/06/14
- [Qemu-devel] [PATCH v6 3/7] qapi: add a QmpInputVisitor that does string conversion, Daniel P. Berrange, 2016/06/14
- [Qemu-devel] [PATCH v6 2/7] option: make parse_option_bool/number non-static, Daniel P. Berrange, 2016/06/14
- [Qemu-devel] [PATCH v6 4/7] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/06/14
- [Qemu-devel] [PATCH v6 5/7] util: add QAuthZ object as an authorization base class, Daniel P. Berrange, 2016/06/14
- [Qemu-devel] [PATCH v6 6/7] util: add QAuthZSimple object type for a simple access control list, Daniel P. Berrange, 2016/06/14
- [Qemu-devel] [PATCH v6 7/7] acl: delete existing ACL implementation, Daniel P. Berrange, 2016/06/14
- Re: [Qemu-devel] [PATCH v6 0/7] Provide a QOM-based authorization API, Daniel P. Berrange, 2016/06/27