[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 30/34] virtio-bus: have callers tolerate new host
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PULL 30/34] virtio-bus: have callers tolerate new host notifier api |
|
Date: |
Wed, 29 Jun 2016 13:48:40 +0200 |
On Wed, 29 Jun 2016 13:37:15 +0200
Marc-André Lureau <address@hidden> wrote:
> Hi
>
> On Fri, Jun 24, 2016 at 7:55 AM, Michael S. Tsirkin <address@hidden> wrote:
> > From: Cornelia Huck <address@hidden>
> >
> > Have vhost and dataplane use the new api for transports that
> > have been converted.
> >
> > Signed-off-by: Cornelia Huck <address@hidden>
> > Reviewed-by: Fam Zheng <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
>
> This patch and further break vhost-user-test:
>
> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/vhost-user-test
> /x86_64/vhost-user/read-guest-mem: binding does not support host notifiers
> qemu-system-x86_64: unable to start vhost net: 38: falling back on
> userspace virtio
> **
> ERROR:tests/vhost-user-test.c:162:wait_for_fds: assertion failed: (s->fds_num)
> Aborted (core dumped)
Yes, there's an || that needs to be a && (too late to fix), and the
mechanism does not work for vhost (currently working on a fix; our
fallback is too good since it only prints a message but otherwise
works).