[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include <sys/uio.h>
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include <sys/uio.h> |
Date: |
Thu, 30 Jun 2016 14:57:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Greg Kurz <address@hidden> writes:
> The <sys/uio.h> system header doesn't exist on all host platforms. Code should
> include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't
> define CONFIG_IOVEC (like win32, if it is to support 9p one day).
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> fsdev/9p-iov-marshal.c | 1 -
> fsdev/9p-marshal.c | 1 -
> fsdev/file-op-9p.h | 2 +-
> 3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
> index fb40bdf0d5f6..a564637b73c1 100644
> --- a/fsdev/9p-iov-marshal.c
> +++ b/fsdev/9p-iov-marshal.c
> @@ -15,7 +15,6 @@
> #include <glib.h>
> #include <glib/gprintf.h>
> #include <utime.h>
> -#include <sys/uio.h>
>
> #include "9p-iov-marshal.h"
> #include "qemu/bswap.h"
> diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c
> index 183d3667c681..df9d4f8e23c9 100644
> --- a/fsdev/9p-marshal.c
> +++ b/fsdev/9p-marshal.c
> @@ -16,7 +16,6 @@
> #include <glib/gprintf.h>
> #include <dirent.h>
> #include <utime.h>
> -#include <sys/uio.h>
>
> #include "9p-marshal.h"
>
> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
> index b8c26024a955..8736d1fa6d52 100644
> --- a/fsdev/file-op-9p.h
> +++ b/fsdev/file-op-9p.h
> @@ -12,9 +12,9 @@
> */
> #ifndef _FILEOP_H
> #define _FILEOP_H
> +#include "qemu/osdep.h"
Every .c file must include qemu/osdep.h first. You can and should rely
on that in headers. Please drop this include.
> #include <dirent.h>
> #include <utime.h>
> -#include <sys/uio.h>
> #include <sys/vfs.h>
>
> #define SM_LOCAL_MODE_BITS 0600