|
From: | Jason Wang |
Subject: | Re: [Qemu-devel] [RFC PATCH V2 2/3] filter-rewriter: track connection and parse packet |
Date: | Mon, 4 Jul 2016 16:29:06 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 2016年07月04日 15:47, Zhang Chen wrote:
+ if (is_tcp_packet(pkt)) { + if (sender == nf->netdev) { + fill_connection_key(pkt, &key, SECONDARY); + } else { + fill_connection_key(pkt, &key, PRIMARY); + } + + conn = connection_get(s->connection_track_table, + &key, + &s->hashtable_size); + if (!conn->processing) { + qemu_mutex_lock(&s->conn_list_lock); + g_queue_push_tail(&s->conn_list, conn); + qemu_mutex_unlock(&s->conn_list_lock);conn_list was never used in this series, and I fail to understand why conn_list is needed?When filter-rewriter work with colo-frame we need this do some synchronization job.like colo do checkpoint,we will flush connection.Maybe I should move this lock to other patch (like filter-rewriter work with colo-frame).ThanksZhang Chen
Yes, please do it.
[Prev in Thread] | Current Thread | [Next in Thread] |