[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG |
|
Date: |
Mon, 4 Jul 2016 12:10:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 02/07/2016 09:38, Sergey Fedorov wrote:
>>>> >>> +bool qemu_tcg_mttcg_enabled(void)
>>>> >>> +{
>>>> >>> + return mttcg_enabled;
>>>> >>> +}
>>> >> Is there a good reason to expose this via function call, rather than
>>> >> just test
>>> >> the variable?
>> > It was in Fred's original patch. I guess there could be an argument
>> > versus a global variable but as mttcg_enabled is set during option
>> > parsing we don't need to do anything dynamic.
> I think it just resembles tcg_enabled(), kvm_enabled() etc.
Those are macros however, not functions. They are macros in order to
cull KVM code for files that are compiled per-target.
Paolo