[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] coroutine: reduce stack size to 64kB
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/6] coroutine: reduce stack size to 64kB |
|
Date: |
Mon, 4 Jul 2016 12:20:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 04/07/2016 08:22, Peter Lieven wrote:
>>>
>>
>> Ought we check that this is not smaller than
>>
>> sysconf(_SC_THREAD_STACK_MIN)
>>
>> which (for glibc at least), is 192k for ia64, 128k for aarch64, mips
>> and tile (though why it is quite so high in those later cases I don't
>> know).
>
> for x86_64 it seems to be 16k. I would not mind to adjust the stack size
> either in qemu_alloc_stack or change the macro for the coroutine stack
> size into a function returning MAX(1 << 16, sysconf(_SC_THREAD_STACK_MIN)).
Yes, either of this is a good idea.
Paolo