[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() retu
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() return value |
|
Date: |
Tue, 5 Jul 2016 00:01:49 +0200 |
On Mon, Jul 4, 2016 at 5:46 PM, Michael S. Tsirkin <address@hidden> wrote:
> Let's just work on handling it. If we need debug messages to help us
> reach that goal fine. But I don't see many reasons to propagate
> return codes back and forth if caller just prints and ignores it.
> Print it where it's detected :)
Adding more debug messages is not the point of this patch though, it
is to break the code flow when an error occurs, not later. Sure we can
add error_report() in vhost_user_write() that would be more consistent
with vhost_user_read() actually.
--
Marc-André Lureau