[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting durin
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse |
|
Date: |
Tue, 5 Jul 2016 15:19:16 +0800 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, 07/05 15:16, Changlong Xie wrote:
> On 07/05/2016 02:56 PM, Fam Zheng wrote:
> > On Mon, 07/04 14:40, Paolo Bonzini wrote:
> > > Now that json-streamer tries not to leak tokens on incomplete parse,
> > > the tokens can be freed twice if QEMU destroys the json-streamer
> > > object during the parser->emit call. To fix this, create the new
> > > empty GQueue earlier, so that it is already in place when the old
> > > one is passed to parser->emit.
> > >
> > > Reported-by: Changlong Xie <address@hidden>
> > > Signed-off-by: Paolo Bonzini <address@hidden>
> >
> > Two meta questions:
> >
> > Is there a reproducer and/or test case coverage?
>
> tests/qemu-iotests/071
>
> >
> > Does qemu-stable need this?
> >
>
> http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg00465.html
Get it! Thanks!
Fam