[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char: do not use atexit cleanup handler
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] char: do not use atexit cleanup handler |
Date: |
Tue, 5 Jul 2016 10:24:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 04/07/2016 21:53, Gerd Hoffmann wrote:
> Hi,
>
>>>> What about graphics threads ? In particular I'd be thinking of spice
>>>> which uses threads and chardevs.
>>>
>>> I think it should be quiesced after pause_all_vcpus returns. Marc-André
>>> should know, but it's better to check with Gerd.
>>
>> In theory, spice_server_vm_stop() should be called at this point,
>
> Yes, that should handle the qxl worker thread.
>
>> and all chardev in spice are stopped too there, as well as the qxl
>> worker processing thread (although the thread is not joined here
>> neither..).
>
> The chardevs are handled in iothread context anyway, so I don't think
> they need any special care.
Writes to chardevs can be done from non-iothread threads, but SPICE
doesn't do that.
Paolo