|
| From: | Peter Lieven |
| Subject: | Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() |
| Date: | Tue, 5 Jul 2016 15:40:45 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
Am 05.07.2016 um 15:37 schrieb Paolo Bonzini:
On 05/07/2016 03:53, Eric Blake wrote:I think we cannot assert that that these alignments are a power of 2.Perhaps that means we should just fix our code to round things down to the nearest power of 2 (8MB) for the opt_transfer_len and opt_discard_alignment values. Can you post a stack-trace of the actual assertion you are hitting?It doesn't work for opt_discard_alignment. Neither 8MB nor 16MB is aligned to 15MB for example.
Right, we should keep these limits. And if we need to round down for any reason we should use the gcd of both values. Peter
| [Prev in Thread] | Current Thread | [Next in Thread] |