[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] std: add cp437 to unicode map
|
From: |
Kevin O'Connor |
|
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] std: add cp437 to unicode map |
|
Date: |
Tue, 5 Jul 2016 09:49:02 -0400 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, Jul 04, 2016 at 10:39:52PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
Nice!
[...]
> --- /dev/null
> +++ b/src/std/cp437.h
Instead of making a header file and including it in an array in the C
code I think it would be better to instead introduce cp437.c with:
u16 sercon_cp437[256] VARFSEG = {
...
};
[...]
> +[ 0x7f ] = 0x007f, // DELETE
That should be 0x2302 (see the wikipedia page).
-Kevin