qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores
Date: Tue, 5 Jul 2016 16:55:44 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 07/05/2016 02:41 PM, Michael Rolnik wrote:
right it accesses CPU registers but from helper context.
the flow is as follows

1. there is a write to [0x0000: 0x0100) region
2. tlb_fill is called, it does the following
    a. sets env->fullwr
    b. calls cpu_loop_exit_restore.
    c. the whole block is retranslated and instead of st it generates
helper_fullwr for each store within this TB.
3. helper_fullwr calls cpu_physical_memory_write
4. sample_io_write is called and register is changed since the whole thing is
done from within a helper

It is my opinion that helper_fullwr should simply modify the respective registers. There's no point adding two more layers of calls.

You also need to reset env->fullwr at some point.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]