Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source

[Markus Armbruster]

Sascha Silbe <address@hidden> writes:

> Dear Markus,
>
> Markus Armbruster <address@hidden> writes:
>
>> Markus Armbruster <address@hidden> writes:
>>
>>> Hmm, this demonstrates some of our headers may only be included when
>>> certain CONFIG_* are defined.
> [...]
>>> Regardless, we need to find the problemtatic headers.  Perhaps you can
>>> find a few more with "make -k check-source".
>>
>> I think I tracked them down.  Not too bad, just a dozen or so.  Now I
>> have to make up my mind whether I prefer to document their configuration
>> requirements with comments or with ifdefs.
>
> FWIW, I'd prefer a solution that allows successfully running "make
> check-source" even on hosts where not all optional dependencies are
> installed. It would be useful as a sanity check before sending
> patches. If "make check-source" doesn't work on the developers primary
> machine because they cannot install all the latest experimental
> dependencies, fewer submitters will use it.

Agree.