[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting durin
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse |
|
Date: |
Wed, 6 Jul 2016 16:45:02 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/07/2016 16:30, Markus Armbruster wrote:
> Paolo Bonzini <address@hidden> writes:
>
>> Now that json-streamer tries not to leak tokens on incomplete parse,
>> the tokens can be freed twice if QEMU destroys the json-streamer
>> object during the parser->emit call. To fix this, create the new
>> empty GQueue earlier, so that it is already in place when the old
>> one is passed to parser->emit.
>>
>> Reported-by: Changlong Xie <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
> Want me to do the pull request?
I'm doing one tomorrow, so your choice.
Paolo