Re: [Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare

[Zhang Chen]

Hi~~ Jason~

Have any comments?
By the way this patch set depend on the patch
[RFC PATCH V2] qemu-char: Fix context for g_source_attach()
but no one review it....any suggestion?


Thanks
Zhang Chen


On 06/23/2016 07:34 PM, Zhang Chen wrote:
> COLO-compare is a part of COLO project. It is used
> to compare the network package to help COLO decide
> whether to do checkpoint.
>
> the full version in this github:
> https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-compare-with-colo-base-jun20
>
> v5:
>   p3:
>      - comments from Jason
>        we poll and handle chardev in comapre thread,
>        Through this way, there's no need for extra
>        synchronization with main loop
>        this depend on another patch:
>        qemu-char: Fix context for g_source_attach()
>      - remove QemuEvent
>   p2:
>      - remove conn->list_lock
>   p1:
>      - move compare_pri/sec_chr_in to p3
>      - move compare_chr_send to p2
>
> v4:
>   p4:
>      - add some comments
>      - fix some trace-events
>      - fix tcp compare error
>   p3:
>      - add rcu_read_lock().
>      - fix trace name
>      - fix jason's other comments
>      - rebase some Dave's branch function
>   p2:
>      - colo_compare_connection() change g_queue_push_head() to
>      - g_queue_push_tail() match to sorted order.
>      - remove pkt->s
>      - move data structure to colo-base.h
>      - add colo-base.c reuse codes for filter-rewriter
>      - add some filter-rewriter needs struct
>      - depends on previous SocketReadState patch
>   p1:
>      - except move qemu_chr_add_handlers()
>        to colo thread
>      - remove class_finalize
>      - remove secondary arp codes
>      - depends on previous SocketReadState patch
>
> v3:
>    - rebase colo-compare to colo-frame v2.7
>    - fix most of Dave's comments
>      (except RCU)
>    - add TCP,UDP,ICMP and other packet comparison
>    - add trace-event
>    - add some comments
>    - other bug fix
>    - add RFC index
>    - add usage in patch 1/4
>
> v2:
>    - add jhash.h
>
> v1:
>    - initial patch
>
>
> Zhang Chen (4):
>    colo-compare: introduce colo compare initialization
>    colo-compare: track connection and enqueue packet
>    colo-compare: introduce packet comparison thread
>    colo-compare: add TCP,UDP,ICMP packet comparison
>
>   include/qemu/jhash.h |  61 +++++
>   net/Makefile.objs    |   2 +
>   net/colo-base.c      | 195 ++++++++++++++
>   net/colo-base.h      |  91 +++++++
>   net/colo-compare.c   | 742 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   qemu-options.hx      |  34 +++
>   trace-events         |  11 +
>   vl.c                 |   3 +-
>   8 files changed, 1138 insertions(+), 1 deletion(-)
>   create mode 100644 include/qemu/jhash.h
>   create mode 100644 net/colo-base.c
>   create mode 100644 net/colo-base.h
>   create mode 100644 net/colo-compare.c

--
Thanks
zhangchen