Re: [Qemu-devel] [PATCH v2] qapi: change QmpInputVisitor to QSLIST

[Eric Blake]

On 07/07/2016 05:27 AM, Paolo Bonzini wrote:
> This saves a lot of memory compared to a statically-sized array,
> or at least 24kb could be considered a lot on an Atari ST.
> 
> It also makes the code more similar to QmpOutputVisitor.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>         v1->v2: leave assert in check_struct [Eric, Markus]
> 
>  qapi/qmp-input-visitor.c | 54 
> ++++++++++++++++++++++++------------------------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 

> -static void qmp_input_pop(Visitor *v)
> +static void qmp_input_stack_pop(QmpInputVisitor *qiv)
>  {
> -    QmpInputVisitor *qiv = to_qiv(v);
> -    StackObject *tos = &qiv->stack[qiv->nb_stack - 1];
> -

> +}
> +
> +static void qmp_input_pop(Visitor *v)
> +{
> +    QmpInputVisitor *qiv = to_qiv(v);
> +
> +    qmp_input_stack_pop(qiv);
>  }

I'm not entirely convinced we needed to separate qmp_input_pop() from
qmp_input_stack_pop(), but I'm not opposed to it enough to stop review.

Reviewed-by: Eric Blake <address@hidden>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature