Re: [Qemu-devel] [PATCH v4 00/11] Allow creating block jobs with a user-defined ID

[John Snow]

On 07/07/2016 11:12 AM, Alberto Garcia wrote:
> On Thu 07 Jul 2016 02:48:17 PM CEST, Kevin Wolf wrote:
>>> Hi all,
>>>
>>> block jobs are currently identified by the name of the block backend
>>> of the BDS where the job was started.
>>>
>>> The problem with this is that you cannot have block jobs on nodes
>>> where there is no such name.
>>>
>>> This series turns the 'id' field of the BlockJob structure into an
>>> actual ID, it guarantees that is unique and always present and allows
>>> the user to set it.
>>
>> Thanks, applied to the block branch.
> 
> Thanks Kevin,
> 
> I would still like to have an ACK from John Snow, not necessarily a
> complete review of the series but I definitely want to avoid any
> fundamental conflict with the "Jobs 2.0 API" that is in the works.
> 
> Berto
> 

It's fine, I'm lagging behind with my upstream stuff. You're doing the
work and I'm not right now, so I lose my chance to complain :)

I appreciate the kindness, though.

ACK.