[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] qapi: change QmpInputVisitor to QSLIST
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] qapi: change QmpInputVisitor to QSLIST |
Date: |
Thu, 7 Jul 2016 12:30:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/07/2016 09:53 AM, Paolo Bonzini wrote:
> This saves a lot of memory compared to a statically-sized array,
> or at least 24kb could be considered a lot on an Atari ST.
> It also makes the code more similar to QmpOutputVisitor.
>
> This removes the limit on the depth of a QObject that can be processed
> into a QAPI tree. This is not a problem because QObjects can be
> considered truested; the text received on the QMP wire is untrusted
s/truested/trusted/
> input, but the JSON parser already takes pains to limit the QObject tree
> it creates. We don't need the QMP input visitor to limit it again.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qapi/qmp-input-visitor.c | 59
> ++++++++++++++++++++++++------------------------
> 1 file changed, 29 insertions(+), 30 deletions(-)
>
With commit message tweak here and comment tweak in 1/2,
Series:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature