Re: [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path

[Alex Bennée]

Paolo Bonzini <address@hidden> writes:

> On 07/07/2016 18:04, Emilio G. Cota wrote:
>>> > I think the first 3 patches are ready to take if the TCG maintainers
>>> > want to:
>>> >
>>> >     tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock'
>>> >     tcg: set up tb->page_addr before insertion
>>> >     tcg: cpu-exec: remove tb_lock from the hot-path
>> I think it would be simpler to use tb_lock_recursive and
>> tb_lock_reset, as pointed out in v1 of this series.
>
> I agree, this series is doing a lot more restructuring than necessary.

Really I thought the first 3 patches where simplifying things - that's
why I moved the more aggressive stuff into follow on patches. Wouldn't
using tb_lock_recursive inside the mmap_lock() run the risk of a deadlock?

>
> Paolo


--
Alex Bennée