qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vnc: fix incorrect checking condition when upda


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH] vnc: fix incorrect checking condition when updating client
Date: Fri, 8 Jul 2016 09:58:07 +0100
User-agent: Mutt/1.6.1 (2016-04-27)

On Fri, Jul 08, 2016 at 11:37:36AM +0800, Gonglei wrote:
> vs->disconnecting is set to TRUE and vs->ioc is closed, but
> vs->ioc isn't set to NULL, so that the vnc_disconnect_finish()
> isn't invoked when you update client in vnc_update_client()
> after vnc_disconnect_start invoked. Let's using change the checking
> condition to avoid resource leak.
> 
> Signed-off-by: Haibin Wang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
>  ui/vnc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrange <address@hidden>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]