Re: [Qemu-devel] [V12 3/4] hw/i386: Introduce AMD IOMMU

[Jan Kiszka]

Yes, this is what i meant. 

Am 8. Juli 2016 09:01:59 MESZ, schrieb David Kiarie <address@hidden>:
>On Mon, Jul 4, 2016 at 8:41 AM, Jan Kiszka <address@hidden> wrote:
>> On 2016-07-04 07:06, David Kiarie wrote:
>>> On Wed, Jun 22, 2016 at 11:24 PM, Jan Kiszka <address@hidden>
>wrote:
>>>> On 2016-06-15 14:21, David Kiarie wrote:
>>>>> +
>>>>> +
>>>>> +/* PCI SIG constants */
>>>>> +#define PCI_BUS_MAX 256
>>>>> +#define PCI_SLOT_MAX 32
>>>>> +#define PCI_FUNC_MAX 8
>>>>> +#define PCI_DEVFN_MAX 256
>>>>
>>>> Shouldn't those four go to the pci header?
>>>
>>> The macros/defines in PCI header are picked from linux while some of
>>> these are not picked from linux. I'v prefixed them with AMDVI_
>though.
>>
>> They are not AMDVI-specific, rather PCI-generic.
>
>Am I getting you right here, the above should go into PCI header, right
>?
>
>>
>> Jan
>>
>>

-- 
Sent from an Android - sorry, just in case...