qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/5] nbd: Drop unused offset parameter


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 5/5] nbd: Drop unused offset parameter
Date: Fri, 8 Jul 2016 13:11:16 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 21.06.2016 um 01:39 hat Eric Blake geschrieben:
> Now that NBD relies on the block layer to fragment things, we no
> longer need to track an offset argument for which fragment of
> a request we are actually servicing.
> 
> While at it, use true and false instead of 0 and 1 for a bool
> parameter.
> 
> Signed-off-by: Eric Blake <address@hidden>

> @@ -35,7 +34,7 @@ ssize_t nbd_wr_syncv(QIOChannel *ioc,
> 
>      nlocal_iov = iov_copy(local_iov, nlocal_iov,
>                            iov, niov,
> -                          offset, length);
> +                          0, length);

This statement fits in a single line instead of three.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]