[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 26/43] vvfat: Use BdrvChild for s->qcow
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 26/43] vvfat: Use BdrvChild for s->qcow |
Date: |
Mon, 11 Jul 2016 16:02:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 05/07/2016 17:50, Kevin Wolf wrote:
> +};
> +
> +static int enable_write_target(BlockDriverState *bs, Error **errp)
> +{
> + BDRVVVFATState *s = bs->opaque;
> BlockDriver *bdrv_qcow = NULL;
> BlockDriverState *backing;
> QemuOpts *opts = NULL;
> @@ -3000,8 +3020,8 @@ static int enable_write_target(BDRVVVFATState *s, Error
> **errp)
>
> options = qdict_new();
> qdict_put(options, "driver", qstring_from_str("qcow"));
> - s->qcow = bdrv_open(s->qcow_filename, NULL, options,
> - BDRV_O_RDWR | BDRV_O_NO_FLUSH, errp);
> + s->qcow = bdrv_open_child(s->qcow_filename, options, "write-target", bs,
> + &child_vvfat_qcow, false, errp);
> if (!s->qcow) {
> ret = -EINVAL;
> goto err;
For whatever reason, Coverity now notices that the "options" QDict is
leaked. Who's right?
Paolo
- Re: [Qemu-devel] [PULL 18/43] block: Switch discard length bounds to byte-based, (continued)
- [Qemu-devel] [PULL 19/43] block: Drop raw_refresh_limits(), Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 20/43] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 24/43] block: fix return code for partial write for Linux AIO, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 22/43] block: Fix error message style, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 27/43] blkreplay: Convert to byte-based I/O, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 21/43] block: Move request_alignment into BlockLimit, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 23/43] block: Use bool as appropriate for BDS members, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 25/43] block/qdev: Fix NULL access when using BB twice, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 26/43] vvfat: Use BdrvChild for s->qcow, Kevin Wolf, 2016/07/05
- Re: [Qemu-devel] [PULL 26/43] vvfat: Use BdrvChild for s->qcow,
Paolo Bonzini <=
- [Qemu-devel] [PULL 28/43] vhdx: Some more BlockBackend use in vhdx_create(), Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 30/43] block: Convert bdrv_co_writev() to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 29/43] block: Convert bdrv_co_readv() to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 33/43] block: Convert bdrv_co_do_readv/writev to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 32/43] block: Convert bdrv_aio_writev() to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 31/43] block: Convert bdrv_aio_readv() to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 35/43] block: Use BlockBackend for I/O in bdrv_commit(), Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 37/43] block: Convert bdrv_write() to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 36/43] block: Convert bdrv_read() to BdrvChild, Kevin Wolf, 2016/07/05
- [Qemu-devel] [PULL 34/43] block: Move bdrv_commit() to block/commit.c, Kevin Wolf, 2016/07/05