[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] linux-user: Fix memchr() argument in open_self_
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 8/8] linux-user: Fix memchr() argument in open_self_cmdline() |
Date: |
Tue, 12 Jul 2016 13:02:19 +0100 |
In open_self_cmdline() we look for a 0 in the buffer we read
from /prc/self/cmdline. We were incorrectly passing the length
of our buf[] array to memchr() as the length to search, rather
than the number of bytes we actually read into it, which could
be shorter. This was spotted by Coverity (because it could
result in our trying to pass a negative length argument to
write()).
Signed-off-by: Peter Maydell <address@hidden>
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f849a5d..9dbd711 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6530,7 +6530,7 @@ static int open_self_cmdline(void *cpu_env, int fd)
if (!word_skipped) {
/* Skip the first string, which is the path to qemu-*-static
instead of the actual command. */
- cp_buf = memchr(buf, 0, sizeof(buf));
+ cp_buf = memchr(buf, 0, nb_read);
if (cp_buf) {
/* Null byte found, skip one string */
cp_buf++;
--
1.9.1
- [Qemu-devel] [PATCH 0/8] linux-user: fix various coverity nits, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 1/8] linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 2/8] linux-user: Check lock_user() return value for NULL, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 5/8] linux-user: Don't write off end of new_utsname buffer, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 7/8] linux-user: Use glib malloc functions in load_symbols(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 6/8] linux-user: Check dump_write() return in elf_core_dump(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 4/8] linux-user: Fix error handling in flatload.c target_pread(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 3/8] linux-user: Fix incorrect use of host errno in do_ioctl_dm(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 8/8] linux-user: Fix memchr() argument in open_self_cmdline(),
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/8] linux-user: fix various coverity nits, Paolo Bonzini, 2016/07/12