[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time |
|
Date: |
Tue, 12 Jul 2016 15:42:58 +0200 |
On Tue, 12 Jul 2016 14:48:43 +0200
Igor Mammedov <address@hidden> wrote:
> On Tue, 12 Jul 2016 00:29:08 -0300
> Eduardo Habkost <address@hidden> wrote:
[...]
> > 1) x86_cpu_realizefn():
> > if (cpu->env.features[FEAT_1_EDX] & CPUID_APIC || smp_cpus > 1) {
> > x86_cpu_apic_create(cpu, &local_err);
Usage of smp_cpus here looks incorrect to me, it should be max_cpus.
But we can't make it max_cpus without compat glue as it will break
backwards migration (not that upstream cares about it)
- Re: [Qemu-devel] [PATCH v3 07/19] pc: set APIC ID based on socket/core/thread ids if it's not been set yet, (continued)
[Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback, Igor Mammedov, 2016/07/06
[Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Igor Mammedov, 2016/07/06
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Eduardo Habkost, 2016/07/12
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Igor Mammedov, 2016/07/13
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Eduardo Habkost, 2016/07/13
[Qemu-devel] [PATCH v3 10/19] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug(), Igor Mammedov, 2016/07/06