Re: [Qemu-devel] [PATCH 4/9] address_space_write_continue: Distill common code

[Andrey Smirnov]

On Tue, Jul 12, 2016 at 8:41 AM, Peter Maydell <address@hidden> wrote:
> On 12 July 2016 at 16:28, Andrey Smirnov <address@hidden> wrote:
>> On Thu, Jul 7, 2016 at 8:38 PM, David Gibson
>> <address@hidden> wrote:
>>> On Thu, Jul 07, 2016 at 04:33:38PM -0700, Andrey Smirnov wrote:
>>>> Move call to memory_region_dispatch_write() outside of swtich statement
>>>> since the only thing that is different about all of those call is
>>>> "length" argument and that matches value in "l". Also collapse switch
>>>> statement to occupy less vertical space.
>>>>
>>>> Signed-off-by: Andrey Smirnov <address@hidden>
>>>
>>> I'm not a big fan of putting multiple statements on a single line,
>>> especially flow control like break.  But apart from that,
>>
>> I don't usually do it either, except in simple cases like this where a
>> lot of vertical real estate can be gained without making the code more
>> difficult to read. All of that is IMHO, of course. I am not
>> particularly attached to this formatting so if people want me to
>> change this I'll happily oblige.
>
> We don't generally do multi-statement lines (does checkpatch
> complain about this), so I'd favour retaining the newlines.
> Not a big deal either way though.

I need to send the patches again anyway, since they were bounced by
nongnu.org due to some problems in e-mail header, so I'll make this
change and mark them v3 (plus any other changes that we decide are
needed).

Andrey