[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB |
Date: |
Tue, 12 Jul 2016 11:39:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/12/2016 10:23 AM, Peter Lieven wrote:
> evaluation with the recently introduced maximum stack usage monitoring
> revealed
> that the actual used stack size was never above 4kB so allocating 1MB stack
> for each coroutine is a lot of wasted memory. So reduce the stack size to
> 64kB which should still give enough head room. The guard page added
> in qemu_alloc_stack will catch a potential stack overflow introduced
> by this commit.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> include/qemu/coroutine_int.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h
> index eac323a..f84d777 100644
> --- a/include/qemu/coroutine_int.h
> +++ b/include/qemu/coroutine_int.h
> @@ -28,7 +28,7 @@
> #include "qemu/queue.h"
> #include "qemu/coroutine.h"
>
> -#define COROUTINE_STACK_SIZE (1 << 20)
> +#define COROUTINE_STACK_SIZE (1 << 16)
>
> typedef enum {
> COROUTINE_YIELD = 1,
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V5 0/6], Peter Lieven, 2016/07/12
- [Qemu-devel] [PATCH V5 5/6] oslib-posix: add a configure switch to debug stack usage, Peter Lieven, 2016/07/12
- [Qemu-devel] [PATCH V5 2/6] coroutine: add a macro for the coroutine stack size, Peter Lieven, 2016/07/12
- [Qemu-devel] [PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free, Peter Lieven, 2016/07/12
- [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB, Peter Lieven, 2016/07/12
- Re: [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB,
Eric Blake <=
- [Qemu-devel] [PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory, Peter Lieven, 2016/07/12
- [Qemu-devel] [PATCH V5 4/6] coroutine-sigaltstack: use helper for allocating stack memory, Peter Lieven, 2016/07/12
- Re: [Qemu-devel] [PATCH V5 0/6] coroutine: mmap stack memory and stack size, Peter Lieven, 2016/07/27