qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering ass


From: Emilio G. Cota
Subject: Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions
Date: Tue, 12 Jul 2016 19:19:17 -0400
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Jul 12, 2016 at 23:13:36 +0300, Sergey Fedorov wrote:
> From: Sergey Fedorov <address@hidden>
> It is naturally expected that some memory ordering should be provided
> around qht_insert(), qht_remove(), and qht_lookup(). Document these
> assumptions in the header file and put some comments in the source to
> denote how that memory ordering requirements are fulfilled.

I wouldn't put those comments in the source--seqlock callers should
know what they're doing, and what barriers seqlocks imply.

I'm OK with stating what the implied ordering is in the header
file, though.

Thanks,

                Emilio



reply via email to

[Prev in Thread] Current Thread [Next in Thread]