Re: [Qemu-devel] [PATCH v4 3/6] virtio-blk: Call virtio_add_queue_aio

[Cornelia Huck]

On Wed, 13 Jul 2016 13:09:45 +0800
Fam Zheng <address@hidden> wrote:

> AIO based handler is more appropriate here because it will then
> cooperate with bdrv_drained_begin/end. It is needed by the coming
> revert patch.

Not sure whether you really need to refer to an upcoming patch: I think
it is enough for the revert patch to refer to this and the virtio-scsi
patch. (I'm always a bit confused if I see things like this in the log
later on.)

> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  hw/block/virtio-blk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index ae86e94..97578a4 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -913,7 +913,7 @@ static void virtio_blk_device_realize(DeviceState *dev, 
> Error **errp)
>      s->sector_mask = (s->conf.conf.logical_block_size / BDRV_SECTOR_SIZE) - 
> 1;
> 
>      for (i = 0; i < conf->num_queues; i++) {
> -        virtio_add_queue(vdev, 128, virtio_blk_handle_output);
> +        virtio_add_queue_aio(vdev, 128, virtio_blk_handle_output);
>      }
>      virtio_blk_data_plane_create(vdev, conf, &s->dataplane, &err);
>      if (err != NULL) {

Reviewed-by: Cornelia Huck <address@hidden>