[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mir
From: |
Denis V. Lunev |
Subject: |
[Qemu-devel] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mirror_run a bit |
Date: |
Thu, 14 Jul 2016 16:33:27 +0300 |
There is no need to scan allocation tables if we have mark_all_dirty flag
set. Just mark it all dirty.
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy<address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>
CC: Jeff Cody <address@hidden>
---
block/mirror.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 3185ccb..d0fa457 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -531,11 +531,15 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJob
*s)
BlockDriverState *base = s->base;
BlockDriverState *bs = blk_bs(s->common.blk);
BlockDriverState *target_bs = blk_bs(s->target);
- bool mark_all_dirty = base == NULL && !bdrv_has_zero_init(target_bs);
int ret, n;
end = s->bdev_length / BDRV_SECTOR_SIZE;
+ if (base == NULL && !bdrv_has_zero_init(target_bs)) {
+ bdrv_set_dirty_bitmap(s->dirty_bitmap, 0, end);
+ return 0;
+ }
+
/* First part, loop on the sectors and initialize the dirty bitmap. */
for (sector_num = 0; sector_num < end; ) {
/* Just to make sure we are not exceeding int limit. */
@@ -554,7 +558,7 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJob *s)
}
assert(n > 0);
- if (ret == 1 || mark_all_dirty) {
+ if (ret == 1) {
bdrv_set_dirty_bitmap(s->dirty_bitmap, sector_num, n);
}
sector_num += n;
--
2.5.0
- [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 5/8] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mirror_run a bit,
Denis V. Lunev <=
- [Qemu-devel] [PATCH v3 2/8] mirror: make sectors_in_flight int64_t, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 7/8] mirror: efficiently zero out target, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: operate with int64_t amount, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 8/8] mirror: improve performance of mirroring of empty disk, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v3 3/8] mirror: create mirror_throttle helper, Denis V. Lunev, 2016/07/14
- Re: [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements, Denis V. Lunev, 2016/07/18