[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for comman
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for commands/events |
Date: |
Thu, 14 Jul 2016 10:23:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/14/2016 08:26 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Turn on the ability to pass command and event arguments in
>> a single boxed parameter, which must name a non-empty type
>> (although the type can be a struct with all optional members).
>> For structs, it makes it possible to pass a single qapi type
>> instead of a breakout of all struct members (useful if the
>> arguments are already in a struct or if the number of members
>> is large); for other complex types, it is now possible to use
>> a union or alternate as the data for a command or event.
>>
...
>> create mode 100644 tests/qapi-schema/args-box-string.json
>> create mode 100644 tests/qapi-schema/args-box-string.out
>> create mode 100644 tests/qapi-schema/event-box-empty.err
>> create mode 100644 tests/qapi-schema/event-box-empty.exit
>> create mode 100644 tests/qapi-schema/event-box-empty.json
>> create mode 100644 tests/qapi-schema/event-box-empty.out
>
> I'm inclined to change box to boxed in the test file names on commit.
> What do you think?
>
Fine by me ('git mv' is up to the task; you'll have to tweak the
Makefile, but that's not too onerous).
> [...]
>> diff --git a/tests/qapi-schema/args-union.json
>> b/tests/qapi-schema/args-union.json
>> index 7bdcbb7..c0ce091 100644
>> --- a/tests/qapi-schema/args-union.json
>> +++ b/tests/qapi-schema/args-union.json
>> @@ -1,4 +1,3 @@
>> -# we do not allow union arguments
>> -# TODO should we support this?
>> +# use of union arguments requires 'box':true
>
> You missed a box here. Can touch up on commit.
Thanks for spotting them all. Yeah, the stragglers are trivial enough
that you can fix on commit.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v9 02/17] qapi: Require all branches of flat union enum to be covered, (continued)
- [Qemu-devel] [PATCH v9 02/17] qapi: Require all branches of flat union enum to be covered, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 05/17] qapi: Add type.is_empty() helper, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 07/17] qapi-event: Simplify visit of non-implicit data, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 04/17] qapi: Hide tag_name data member of variants, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 06/17] qapi: Drop useless gen_err_check(), Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 08/17] qapi: Plumb in 'boxed' to qapi generator lower levels, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 01/17] net: use Netdev instead of NetClientOptions in client init, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for commands/events, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 13/17] net: Use correct type for bool flag, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 11/17] block: Simplify drive-mirror, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 15/17] option: make parse_option_bool/number non-static, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 10/17] block: Simplify block_set_io_throttle, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 14/17] net: Complete qapi-fication of netdev_add, Eric Blake, 2016/07/13
- [Qemu-devel] [PATCH v9 16/17] qapi: Tweak QmpInputVisitor to optionally do string conversion, Eric Blake, 2016/07/13