[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4g
From: |
Bandan Das |
Subject: |
Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb |
Date: |
Thu, 14 Jul 2016 14:48:17 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> On Do, 2016-07-14 at 04:49 -0700, Isaac Lozano wrote:
>> Added support for sending data larger than 4gb.
>
>> Also implemented
>> object properties so that Windows can receive >4gb files.
>
> Can you please split those into two separate patches?
>
>> + case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER:
>> + /* Should be persistant between sessions,
>> + * but using our objedt ID is "good enough"
>> + * for now */
>> + usb_mtp_add_u64(d, 0x0000000000000000);
>> + usb_mtp_add_u64(d, o->handle);
>> + break;
>
> Maybe use the inode number here?
I think it was me who suggested putting in all 0s to him as more of a
todo task :) The inode number should work here.
> cheers,
> Gerd