[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support |
Date: |
Fri, 15 Jul 2016 10:56:19 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, Jul 15, 2016 at 03:49:12PM +0800, Xiao Guangrong wrote:
>
>
> On 07/14/2016 08:17 PM, Stefan Hajnoczi wrote:
> > On Mon, Jul 11, 2016 at 09:45:17PM +0800, Xiao Guangrong wrote:
> > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
> > > index 73fa62d..d1c2e92 100644
> > > --- a/hw/acpi/memory_hotplug.c
> > > +++ b/hw/acpi/memory_hotplug.c
> > > @@ -239,11 +239,6 @@ void acpi_memory_plug_cb(HotplugHandler
> > > *hotplug_dev, MemHotplugState *mem_st,
> > > DeviceState *dev, Error **errp)
> > > {
> > > MemStatus *mdev;
> > > - DeviceClass *dc = DEVICE_GET_CLASS(dev);
> > > -
> > > - if (!dc->hotpluggable) {
> > > - return;
> > > - }
> > >
> > > mdev = acpi_memory_slot_status(mem_st, dev, errp);
> > > if (!mdev) {
> >
> > Did you mean to include this hunk in the patch? Looks like something
> > left over from debugging/prototyping.
> >
>
> As all memory devices, both pc-dimm and nvdimm, have supported hotplug now, i
> think this chunk can be removed.
>
> In fact, this check was introduced by nvdimm. :)
Fair enough.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method, (continued)
- [Qemu-devel] [PATCH 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method, Xiao Guangrong, 2016/07/11
- [Qemu-devel] [PATCH 3/8] nvdimm acpi: introduce _FIT, Xiao Guangrong, 2016/07/11
- [Qemu-devel] [PATCH 4/8] nvdimm acpi: implement Read FIT function, Xiao Guangrong, 2016/07/11
- [Qemu-devel] [PATCH 5/8] pc-dimm: introduce prepare_unplug() callback, Xiao Guangrong, 2016/07/11
- [Qemu-devel] [PATCH 6/8] pc: memhp: do not export nvdimm's memory via _CRS, Xiao Guangrong, 2016/07/11
- [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support, Xiao Guangrong, 2016/07/11
- [Qemu-devel] [PATCH 8/8] nvdimm docs: add nvdimm Read FIT function, Xiao Guangrong, 2016/07/11
- Re: [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support, Igor Mammedov, 2016/07/11
- Re: [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support, Stefan Hajnoczi, 2016/07/14