[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-blk: dataplane cleanup
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-blk: dataplane cleanup |
Date: |
Mon, 18 Jul 2016 13:29:27 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, 07/18 12:05, Cao jin wrote:
> No need duplicate the judgment, there is one in function entry.
>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/block/dataplane/virtio-blk.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> index 54b9ac1..704a763 100644
> --- a/hw/block/dataplane/virtio-blk.c
> +++ b/hw/block/dataplane/virtio-blk.c
> @@ -112,10 +112,8 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev,
> VirtIOBlkConf *conf,
> s->vdev = vdev;
> s->conf = conf;
>
> - if (conf->iothread) {
> - s->iothread = conf->iothread;
> - object_ref(OBJECT(s->iothread));
> - }
> + s->iothread = conf->iothread;
> + object_ref(OBJECT(s->iothread));
> s->ctx = iothread_get_aio_context(s->iothread);
> s->bh = aio_bh_new(s->ctx, notify_guest_bh, s);
> s->batch_notify_vqs = bitmap_new(conf->num_queues);
> --
> 2.1.0
>
>
>
>
Reviewed-by: Fam Zheng <address@hidden>