Re: [Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf

[Jason Wang]

On 2016年07月15日 16:41, Paolo Bonzini wrote:
> Coverity reports a "suspicious sizeof" which is indeed wrong.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>   net/eth.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 95fe15c..0be59c2 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -418,7 +418,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int 
> pkt_frags,
>   
>           bytes_read = iov_to_buf(pkt, pkt_frags,
>                                   rthdr_offset + sizeof(*ext_hdr),
> -                                dst_addr, sizeof(dst_addr));
> +                                dst_addr, sizeof(*dst_addr));
>   
>           return bytes_read == sizeof(dst_addr);
>       }
> @@ -467,7 +467,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int 
> pkt_frags,
>   
>               bytes_read = iov_to_buf(pkt, pkt_frags,
>                                       opt_offset + sizeof(opthdr),
> -                                    src_addr, sizeof(src_addr));
> +                                    src_addr, sizeof(*src_addr));
>   
>               return bytes_read == sizeof(src_addr);
>           }

Applied to -net. Thanks