qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH V7 5/7] qemu-char: Fix context for g_source_


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [RFC PATCH V7 5/7] qemu-char: Fix context for g_source_attach()
Date: Mon, 18 Jul 2016 09:37:49 +0100
User-agent: Mutt/1.6.1 (2016-04-27)

On Mon, Jul 18, 2016 at 03:40:48PM +0800, Zhang Chen wrote:
> We want to poll and handle chardev in another thread
> other than main loop. But qemu_chr_add_handlers() can only
> work for global default context other than thread default context.
> So we use g_source_attach(xx, g_main_context_get_thread_default())
> replace g_source_attach(xx, NULL) to attach g_source.
> Comments from jason.
> 
> Cc: Daniel P . Berrange <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> 
> Signed-off-by: Zhang Chen <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
>  io/channel.c | 2 +-
>  qemu-char.c  | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)

So, on further reflection I'm against adding this patch - please see
my comments against the next patch for why I think this is not needed
nor desirable.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]