[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches |
Date: |
Mon, 18 Jul 2016 13:15:13 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, Jul 15, 2016 at 10:46:54AM +0100, Stefan Hajnoczi wrote:
> Renames look like this with git-diff(1) when diff.renames = true is set:
>
> diff --git a/a b/b
> similarity index 100%
> rename from a
> rename to b
>
> This raises the "Does not appear to be a unified-diff format patch"
> error because checkpatch.pl only considers a diff valid if it contains
> at least one "@@" hunk.
>
> This patch accepts renames and copies too so that checkpatch.pl exits
> successfully when a diff only renames/copies files. The git diff
> extended header format is described on the git-diff(1) man page.
>
> Reported-by: Colin Lord <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> scripts/checkpatch.pl | 5 +++++
> 1 file changed, 5 insertions(+)
There is no maintainer for checkpatch.pl, so...
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature