Re: [Qemu-devel] [PATCH v3 2/2] trace: [bsd-user] Commandline arguments to control tracing

[Stefan Hajnoczi]

On Fri, Jul 15, 2016 at 01:22:54PM -0600, Eric Blake wrote:
> On 07/15/2016 11:08 AM, Lluís Vilanova wrote:
> > Signed-off-by: Lluís Vilanova <address@hidden>
> > ---
> >  bsd-user/main.c |   16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> 
> > @@ -754,6 +760,8 @@ int main(int argc, char **argv)
> >  
> >      cpu_model = NULL;
> >  
> > +    qemu_add_opts(&qemu_trace_opts);
> > +
> >      optind = 1;
> >      for(;;) {
> 
> Optional, but since you are in the area, you could add the missing space
> after 'for'.
> 
> >          if (optind >= argc)
> > @@ -840,6 +848,9 @@ int main(int argc, char **argv)
> >              singlestep = 1;
> >          } else if (!strcmp(r, "strace")) {
> >              do_strace = 1;
> > +        } else if (!strcmp(r, "trace")) {
> > +            g_free(trace_file);
> > +            trace_file = trace_opt_parse(optarg);
> >          } else
> >          {
> 
> and fix the 'else {' to be on one line.

Done while merging.

signature.asc
Description: PGP signature