Re: [Qemu-devel] [PATCH v3 0/2] trace: [*-user] Add commandline arguments to control tracing

[Stefan Hajnoczi]

On Fri, Jul 15, 2016 at 07:08:32PM +0200, Lluís Vilanova wrote:
> Adds three commandline arguments to the main *-user programs, following what's
> already available in softmmu:
> 
> * -trace-enable
> * -trace-events
> * -trace-file
> 
> 
> Changes in v2
> =============
> 
> * Tell user to use 'help' instead of '?' [Eric Blake].
> * Remove newlines on argument docs for bsd-user [Eric Blake].
> 
> 
> Changes in v3
> =============
> 
> * Use new trace_opt_parse() [Stefan Hajnoczi].
> 
> 
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> 
> Lluís Vilanova (2):
>       trace: [linux-user] Commandline arguments to control tracing
>       trace: [bsd-user] Commandline arguments to control tracing
> 
> 
>  bsd-user/main.c   |   16 ++++++++++++++++
>  linux-user/main.c |   19 +++++++++++++++++++
>  2 files changed, 35 insertions(+)
> 
> 
> To: address@hidden
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Eric Blake <address@hidden>

Thank you for quickly rebasing.  I have applied the patch and made Eric
Blake's suggested changes.  I've also changed linux-user.c "const char *
trace_file" to "char *trace_file" since this heap-allocated string needs
to be freed.  The char * type is also used by trace_opt_parse() and
vl.c.

Please remember to run scripts/checkpatch.pl on all patches.  The
easiest way to do that is via a git commit hook described here:
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/HEAD

Stefan

signature.asc
Description: PGP signature