[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL V2 1/6] e1000e: fix incorrect access to pointer
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL V2 1/6] e1000e: fix incorrect access to pointer |
Date: |
Tue, 19 Jul 2016 10:38:50 +0800 |
From: Paolo Bonzini <address@hidden>
This is not dereferencing the pointer, and instead checking only
the value of the pointer.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/e1000e_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 6050d8b..badb1fe 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -281,7 +281,7 @@ e1000e_intrmgr_delay_rx_causes(E1000ECore *core, uint32_t
*causes)
/* Check if delayed RX interrupts disabled by client
or if there are causes that cannot be delayed */
- if ((rdtr == 0) || (causes != 0)) {
+ if ((rdtr == 0) || (*causes != 0)) {
return false;
}
@@ -322,7 +322,7 @@ e1000e_intrmgr_delay_tx_causes(E1000ECore *core, uint32_t
*causes)
*causes &= ~delayable_causes;
/* If there are causes that cannot be delayed */
- if (causes != 0) {
+ if (*causes != 0) {
return false;
}
--
2.7.4
- [Qemu-devel] [PULL V2 0/6] Net patches, Jason Wang, 2016/07/18
- [Qemu-devel] [PULL V2 1/6] e1000e: fix incorrect access to pointer,
Jason Wang <=
- [Qemu-devel] [PULL V2 2/6] net: fix incorrect access to pointer, Jason Wang, 2016/07/18
- [Qemu-devel] [PULL V2 3/6] net: fix incorrect argument to iov_to_buf, Jason Wang, 2016/07/18
- [Qemu-devel] [PULL V2 4/6] tap: fix memory leak on failure to create a multiqueue tap device, Jason Wang, 2016/07/18
- [Qemu-devel] [PULL V2 5/6] MAINTAINERS: release Scott from being a rocker maintainer, Jason Wang, 2016/07/18
- [Qemu-devel] [PULL V2 6/6] e1000e: fix building without CONFIG_VMXNET3_PCI, Jason Wang, 2016/07/18
- Re: [Qemu-devel] [PULL V2 0/6] Net patches, Peter Maydell, 2016/07/19