Re: [Qemu-devel] [PATCH] compiler: never omit assertions if using a static analysis tool

[Richard Henderson]

On 07/15/2016 09:58 PM, Paolo Bonzini wrote:
> Assertions help both Coverity and the clang static analyzer avoid
> false positives, but on the other hand both are confused when
> the condition is compiled as (void)(x != FOO).  Always expand
> assertion macros when using Coverity or clang, through a new
> QEMU_STATIC_ANALYSIS preprocessor symbol.
>
> This fixes a couple false positives in TCG.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/qemu/compiler.h | 3 +++
>  tcg/tcg.h               | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <address@hidden>


r~